git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re* [BUG-ish] diff compaction heuristic false positive

From
Stefan Beller <sbeller@google.com>
Date
Jun 10, 2016, 18:21 UTC
Message-ID
<CAGZ79kZpiPKLS_RFzROznQAE8iT35hV0QXknFMsVcDR7siLOTw@mail.gmail.com>
In-Reply-To
<xmqqeg84gbex.fsf_-_@gitster.mtv.corp.google.com>
On Fri, Jun 10, 2016 at 11:13 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 27 quoted lines
> Subject: [PATCH] diff: disable compaction heuristic for now
>
> http://lkml.kernel.org/g/20160610075043.GA13411@sigill.intra.peff.net
> reports that a change to add a new "function" with common ending
> with the existing one at the end of the file is shown like this:
>
>     def foo
>       do_foo_stuff()
>
>    +  common_ending()
>    +end
>    +
>    +def bar
>    +  do_bar_stuff()
>    +
>       common_ending()
>     end
>
> when the new heuristic is in use.  In reality, the change is to add
> the blank line before "def bar" and everything below, which is what
> the code without the new heuristic shows.
>
> Disable the heuristics by default and leave it as an experimental
> feature for now.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---

Thanks, Stefan

Previous: Junio C HamanoNext: Jeff King
Message 7 of 16 in “[BUG-ish] diff compaction heuristic false positive”
  1. Jeff KingJun 10, 2016
  2. Jeff KingJun 10, 2016
  3. Junio C HamanoJun 10, 2016
  4. Stefan BellerJun 10, 2016
  5. Jacob KellerJun 10, 2016
  6. Re* [BUG-ish] diff compaction heuristic false positiveJunio C Hamano, Jun 10, 2016
  7. Stefan BellerJun 10, 2016
  8. Jeff KingJun 10, 2016
  9. diff: disable compaction heuristic for nowJunio C Hamano, Jun 10, 2016
  10. Jeff KingJun 10, 2016
  11. Junio C HamanoJun 10, 2016
  12. Jeff KingJun 10, 2016
  13. Junio C HamanoJun 10, 2016
  14. Michael HaggertyJun 10, 2016
  15. Jeff KingJun 10, 2016
  16. Michael HaggertyJun 10, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.