Re: Re* [BUG-ish] diff compaction heuristic false positive
- From
Stefan Beller <sbeller@google.com>
- Date
- Jun 10, 2016, 18:21 UTC
- Message-ID
- <CAGZ79kZpiPKLS_RFzROznQAE8iT35hV0QXknFMsVcDR7siLOTw@mail.gmail.com>
- In-Reply-To
- <xmqqeg84gbex.fsf_-_@gitster.mtv.corp.google.com>
On Fri, Jun 10, 2016 at 11:13 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 27 quoted lines
> Subject: [PATCH] diff: disable compaction heuristic for now > > http://lkml.kernel.org/g/20160610075043.GA13411@sigill.intra.peff.net > reports that a change to add a new "function" with common ending > with the existing one at the end of the file is shown like this: > > def foo > do_foo_stuff() > > + common_ending() > +end > + > +def bar > + do_bar_stuff() > + > common_ending() > end > > when the new heuristic is in use. In reality, the change is to add > the blank line before "def bar" and everything below, which is what > the code without the new heuristic shows. > > Disable the heuristics by default and leave it as an experimental > feature for now. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > ---
Thanks, Stefan