Re: [PATCH v2] diff: disable compaction heuristic for now

From: Jeff King <peff@peff.net>
Date: Jun 10, 2016, 20:53 UTC
Message-ID: <20160610205357.GA22470@sigill.intra.peff.net>
In-Reply-To: <xmqqoa78epmt.fsf_-_@gitster.mtv.corp.google.com>

On Fri, Jun 10, 2016 at 01:48:58PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

>     Jeff King <peff@peff.net> writes:
> 
>     > We probably want a patch to the release notes to note that it's not on
>     > by default. And we may want to advertise the experimental knob so
>     > that people actually try it (otherwise we won't get feedback from the
>     > masses).
> 
>     OK, I think that is sensible.  The interdiff is not a strict
>     reversion of 77085a61 (diff: undocument the compaction heuristic
>     knobs for experimentation, 2016-05-02) but stresses that the
>     feature is off by default and is experimental.

Looks good to me. Do we want to include in "experimental" that the option and command-line flag might go away in the future? I think probably not. I do not mind supporting this forever (it _has_ shown its usefulness, so I don't think it is any worse to maintain going forward than things like --patience, which people can tweak if their diff looks uglier than they would like).

-Peff