git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/8] refs.c: rename the transaction functions

From
Stefan Beller <sbeller@google.com>
Date
Dec 11, 2014, 21:48 UTC
Message-ID
<CAGZ79kZVWzvneL=1_5Wp7ANw2A67pjZi08A6g5Y5YN670+RnXQ@mail.gmail.com>
In-Reply-To
<xmqqbnn9eudc.fsf@gitster.dls.corp.google.com>
On Thu, Dec 11, 2014 at 1:42 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> Stefan Beller <sbeller@google.com> writes:
>
>> Rename the transaction functions. Remove the leading ref_ from the
>> names and append _ref to the names for functions that create/delete/
>> update sha1 refs.
>>
>> The goal in the long term is to have different things running through
>> the transaction api, such as the .git/config file.
>>
>> The dream is to...
>
> I was trying to polish somebody else's topic that does not have
> anythning to do with refs/reflogs/transactions today, and had to
> suffer from conflicts from the textual difference between
> transaction_begin and ref_transaction_begin, which I feel is totally
> unnecessary at this moment.
>
> I'd really prefer to see this done long after all the dust from
> "ref" changes from various people have settled, especially given
> that we are not doing anything for that "dream" right now.
>
> Thanks.

Good point. For the last days I was trying to write less invasive patches as I guessed this may become a problem.

Feel free to drop these patches, I'll resend them later if they still make sense.

Previous: Junio C HamanoNext: Stefan Beller
Message 5 of 18 in “Making reflog modifications part of the transactions API”
  1. 0/8 Making reflog modifications part of the transactions APIStefan Beller, Dec 6, 2014
  2. 1/8 refs.c: let fprintf handle the formattingStefan Beller, Dec 6, 2014
  3. 2/8 refs.c: rename the transaction functionsStefan Beller, Dec 6, 2014
  4. Junio C HamanoDec 11, 2014
  5. Stefan BellerDec 11, 2014
  6. 3/8 refs.c: rename transaction.updates to transaction.ref_updatesStefan Beller, Dec 6, 2014
  7. 4/8 refs.c: add transaction function to append to the reflogStefan Beller, Dec 6, 2014
  8. Junio C HamanoDec 11, 2014
  9. 5/8 refs.c: add transaction function to delete the reflogStefan Beller, Dec 6, 2014
  10. 6/8 refs.c: use a reflog transaction when writing during expireStefan Beller, Dec 6, 2014
  11. 7/8 refs.c: rename log_ref_setup to create_reflogStefan Beller, Dec 6, 2014
  12. 8/8 refs.c: allow deleting refs with a broken sha1Stefan Beller, Dec 6, 2014
  13. Stefan BellerDec 8, 2014
  14. Jonathan NiederDec 8, 2014
  15. Michael HaggertyDec 12, 2014
  16. Stefan BellerDec 12, 2014
  17. ronnie sahlbergDec 12, 2014
  18. Michael HaggertyDec 14, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.