[PATCH 1/8] refs.c: let fprintf handle the formatting
- From
Stefan Beller <sbeller@google.com>
- Date
- Dec 6, 2014, 02:46 UTC
- Message-ID
- <1417833995-25687-2-git-send-email-sbeller@google.com>
- In-Reply-To
- <1417833995-25687-1-git-send-email-sbeller@google.com>
Instead of calculating, whether to put a plus or minus sign, offload the responsibilty to the fprintf function.
Signed-off-by: Stefan Beller <sbeller@google.com> ---
Notes:
This patch was already sent as a single patch to the list,
but not yet acknowledge in any way, so I am including it here.
This series goes on top of Michaels series
https://github.com/mhagger/git/tree/reflog-expire-api-v1refs.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/refs.c b/refs.c index 40c5591..1147216 100644 --- a/refs.c +++ b/refs.c @@ -3972,12 +3972,9 @@ static int expire_reflog_ent(unsigned char *osha1, unsigned char *nsha1, printf("prune %s", message); } else { if (cb->newlog) { - char sign = (tz < 0) ? '-' : '+'; - int zone = (tz < 0) ? (-tz) : tz; - fprintf(cb->newlog, "%s %s %s %lu %c%04d\t%s", + fprintf(cb->newlog, "%s %s %s %lu %+05d\t%s", sha1_to_hex(osha1), sha1_to_hex(nsha1), - email, timestamp, sign, zone, - message); + email, timestamp, tz, message); hashcpy(cb->last_kept_sha1, nsha1); } if (cb->flags & EXPIRE_REFLOGS_VERBOSE)
-- 2.2.0