git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/8] Making reflog modifications part of the transactions API

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Dec 8, 2014, 21:54 UTC
Message-ID
<20141208215415.GS16345@google.com>
In-Reply-To
<CAGZ79kb1yiSENO+uANdeOKtcSCZgZA3UXSdE2F5PBA49erh2Jw@mail.gmail.com>
Hi,
Stefan Beller wrote:
> How do we view an empty reflog, i.e. an empty file at logs/refs/heads/master?

That's a good question. I'm a little concerned about what 'git reflog expire --updateref' would do in this case.

It looks like the longstanding behavior is for 'git reflog expire' to expire any entry that is old enough, even if that entry describes the current value of the ref and the reflog becomes empty. The empty reflog file is kind of like having no reflog at all, except it means git should log updates to that ref even if core.logallrefupdates is false.

That suggests that two separate operations delete_reflog (for 'git reflog delete') and truncate_reflog (for 'git reflog expire') would be needed.

Thanks for catching it. Jonathan

Previous: Stefan BellerNext: Michael Haggerty
Message 14 of 18 in “Making reflog modifications part of the transactions API”
  1. 0/8 Making reflog modifications part of the transactions APIStefan Beller, Dec 6, 2014
  2. 1/8 refs.c: let fprintf handle the formattingStefan Beller, Dec 6, 2014
  3. 2/8 refs.c: rename the transaction functionsStefan Beller, Dec 6, 2014
  4. Junio C HamanoDec 11, 2014
  5. Stefan BellerDec 11, 2014
  6. 3/8 refs.c: rename transaction.updates to transaction.ref_updatesStefan Beller, Dec 6, 2014
  7. 4/8 refs.c: add transaction function to append to the reflogStefan Beller, Dec 6, 2014
  8. Junio C HamanoDec 11, 2014
  9. 5/8 refs.c: add transaction function to delete the reflogStefan Beller, Dec 6, 2014
  10. 6/8 refs.c: use a reflog transaction when writing during expireStefan Beller, Dec 6, 2014
  11. 7/8 refs.c: rename log_ref_setup to create_reflogStefan Beller, Dec 6, 2014
  12. 8/8 refs.c: allow deleting refs with a broken sha1Stefan Beller, Dec 6, 2014
  13. Stefan BellerDec 8, 2014
  14. Jonathan NiederDec 8, 2014
  15. Michael HaggertyDec 12, 2014
  16. Stefan BellerDec 12, 2014
  17. ronnie sahlbergDec 12, 2014
  18. Michael HaggertyDec 14, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.