Re: [PATCH v2 03/12] struct ref_update: move "have_old" into "flags"

From: Stefan Beller <sbeller@google.com>
Date: Feb 12, 2015, 18:08 UTC
Message-ID: <CAGZ79kYqx8s8Cz29Qn1aBtCnDOkR-Guk4RM-_KQeO+nHWv=r8w@mail.gmail.com>
In-Reply-To: <1423739543-1025-4-git-send-email-mhagger@alum.mit.edu>

On Thu, Feb 12, 2015 at 3:12 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:

Show 7 quoted lines

> -       int flags; /* REF_NODEREF? */
> -       int have_old; /* 1 if old_sha1 is valid, 0 otherwise */
> +       /*
> +        * One or more of REF_HAVE_OLD, REF_NODEREF,
> +        * REF_DELETING, and REF_IS_PRUNING:
> +        */
> +       int flags;

Nit:
I'd find it more readable if it would be:
    /*
     * One or more of
     * REF_HAVE_OLD,
     * REF_NODEREF,
     * REF_DELETING,
     * REF_IS_PRUNING:
     * whose definition is found at the top of this file.
     */

With or without the nit:
Reviewed-by: Stefan Beller <sbeller@google.com>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.