[PATCH v2 09/12] ref_transaction_delete(): check that old_sha1 is not null_sha1
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Feb 12, 2015, 11:12 UTC
- Message-ID
- <1423739543-1025-10-git-send-email-mhagger@alum.mit.edu>
- In-Reply-To
- <1423739543-1025-1-git-send-email-mhagger@alum.mit.edu>
It makes no sense to delete a reference that is already known not to exist.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Reviewed-by: Stefan Beller <sbeller@google.com> --- refs.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/refs.c b/refs.c index 3f78fac..9dd7932 100644 --- a/refs.c +++ b/refs.c @@ -3702,6 +3702,8 @@ int ref_transaction_delete(struct ref_transaction *transaction, int flags, const char *msg, struct strbuf *err) { + if (old_sha1 && is_null_sha1(old_sha1)) + die("BUG: delete called with old_sha1 set to zeros"); return ref_transaction_update(transaction, refname, null_sha1, old_sha1, flags, msg, err);
-- 2.1.4