git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4 3/5] run-command: add {run,start,finish}_command_or_die

From
Stefan Beller <sbeller@google.com>
Date
Dec 19, 2016, 23:35 UTC
Message-ID
<CAGZ79kY7XpM2zi8CWjZ5d=yBJi1JGz7XkY=d=v+3rVPkF-N4mA@mail.gmail.com>
In-Reply-To
<20161219233256.GB41080@google.com>
On Mon, Dec 19, 2016 at 3:32 PM, Brandon Williams <bmwill@google.com> wrote:
>> +             strbuf_addstr(&err, "git ");
>> +     for (i = 0; cmd->argv[i]; )
>
> Missing the increment of i here.
Doh :(

When writing the code I was undecided between using an incremental loop "for (i = 0; cmd->argv[i]; i++)" and a pointer arithmetic thing as "for(;;) {... cmd->argv++;", and ended up with a broken middle ground.

Previous: Brandon WilliamsNext: Johannes Sixt
Message 5 of 16 in “[PATCHv4 0/5] git-rm absorbs submodule git directory before deletion”
  1. Stefan BellerDec 19, 2016
  2. 1/5 submodule.h: add extern keyword to functionsStefan Beller, Dec 19, 2016
  3. 3/5 run-command: add {run,start,finish}_command_or_dieStefan Beller, Dec 19, 2016
  4. Brandon WilliamsDec 19, 2016
  5. Stefan BellerDec 19, 2016
  6. Johannes SixtDec 20, 2016
  7. Johannes SixtDec 20, 2016
  8. Stefan BellerDec 20, 2016
  9. Johannes SixtDec 20, 2016
  10. Stefan BellerDec 20, 2016
  11. Johannes SixtDec 20, 2016
  12. Stefan BellerDec 20, 2016
  13. 5/5 rm: absorb a submodules git dir before deletionStefan Beller, Dec 19, 2016
  14. 2/5 submodule: modernize ok_to_remove_submodule to use argv_arrayStefan Beller, Dec 19, 2016
  15. 4/5 submodule: add flags to ok_to_remove_submoduleStefan Beller, Dec 19, 2016
  16. David TurnerDec 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.