From: Stefan Beller <sbeller@google.com>
Date: Mon, 19 Dec 2016 23:35:43 GMT
Subject: Re: [PATCHv4 3/5] run-command: add {run,start,finish}_command_or_die
Message-ID: <CAGZ79kY7XpM2zi8CWjZ5d=yBJi1JGz7XkY=d=v+3rVPkF-N4mA@mail.gmail.com>
In-Reply-To: <20161219233256.GB41080@google.com>

On Mon, Dec 19, 2016 at 3:32 PM, Brandon Williams <bmwill@google.com> wrote:

>> +             strbuf_addstr(&err, "git ");
>> +     for (i = 0; cmd->argv[i]; )
>
> Missing the increment of i here.

Doh :(

When writing the code I was undecided between using
an incremental loop "for (i = 0; cmd->argv[i]; i++)" and
a pointer arithmetic thing as "for(;;) {... cmd->argv++;",
and ended up with a broken middle ground.