Re: [External] Re: [PATCH 1/1] revision: don't set parents as uninteresting if exclude promisor objects

> > diff --git a/revision.c b/revision.c
> > index 1c0192f522..eacb0c909d 100644
> > --- a/revision.c
> > +++ b/revision.c
> > @@ -1164,7 +1164,7 @@ static int process_parents(struct rev_info *revs, struct commit *commit,
> >        * wasn't uninteresting), in which case we need
> >        * to mark its parents recursively too..
> >        */
> > -     if (commit->object.flags & UNINTERESTING) {
> > +     if (!revs->exclude_promisor_objects && commit->object.flags & UNINTERESTING) {
> >               while (parent) {
> >                       struct commit *p = parent->item;
> >                       parent = parent->next;
>
> But if the iteration is over all objects in certain packfiles to
> mark them all uninteresting, shouldn't the caller avoid the call to
> process_parents() in the first place?  Letting process_parents() to
> do other things and only refrain from doing the "this commit is
> marked uninteresting" part does not quite match what you are trying
> to do, at least to me.

> It apepars to me that its approach to exclude the objects that
> appear in the promisor packs may be sound, but the design and
> implementation of it is dubious.  Shouldn't it be getting the list
> of objects with get_object_list() WITHOUT paying any attention to
> --exclude-promisor-objects flag, and then filtering objects that
> appear in the promisor packs out of that list, without mucking with
> the object and commit traversal in revision.c at all?