git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/7] i18n: rebase: mark strings for translation

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jul 25, 2012, 09:56 UTC
Message-ID
<CAFzf2XxTs1ynyjxRshrbOgieq-ryzBoY_p7EoGpmrPDyQomU-Q@mail.gmail.com>
In-Reply-To
<CANYiYbHnv0JppT64cnjzBgRq7_pRFHN5WMy2SAVj2GzG+dWBaA@mail.gmail.com>
Jiang Xin wrote:
> 2012/7/25 Jonathan Nieder <jrnieder@gmail.com>:
Show 8 quoted lines
>> I haven't tested or reviewed this patch in detail, so even though it
>> looks good, I'd prefer it not to have my Reviewed-by.  (See
>> Documentation/SubmittingPatches: '"Reviewed-by:", unlike the other
>> extra tags, can only be offered by the reviewer'.)  If you'd like to
>> credit my help, something like "With advice from Jonathan." would be
>> fine.
>
> How about Acked-by: ?

I'm not area expert so my ack wouldn't count for "git rebase" or i18n, anyway. I'm also fine with going unsung --- too many names add up to so much noise, and in general there are some names (author, bug reporter, and so on) that are important and shouldn't be drowned out.

Previous: Jiang Xin
Message 15 of 15 in “i18n for git-am, git-rebase and git-merge”
  1. 0/7 i18n for git-am, git-rebase and git-mergeJiang Xin, Jul 25, 2012
  2. 1/7 i18n: New keywords for xgettext extraction from shJiang Xin, Jul 25, 2012
  3. 2/7 i18n: rebase: mark strings for translationJiang Xin, Jul 25, 2012
  4. 3/7 i18n: Rewrite gettext messages start with dashJiang Xin, Jul 25, 2012
  5. 4/7 Remove obsolete LONG_USAGE which breaks xgettextJiang Xin, Jul 25, 2012
  6. 5/7 i18n: am: mark more strings for translationJiang Xin, Jul 25, 2012
  7. 6/7 Remove dead code which contains bad gettext blockJiang Xin, Jul 25, 2012
  8. 7/7 i18n: merge-recursive: mark strings for translationJiang Xin, Jul 25, 2012
  9. Jonathan NiederJul 25, 2012
  10. Jonathan NiederJul 25, 2012
  11. Stefano LattariniJul 25, 2012
  12. Jiang XinJul 25, 2012
  13. Jonathan NiederJul 25, 2012
  14. Jiang XinJul 25, 2012
  15. Jonathan NiederJul 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.