From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 25 Jul 2012 09:56:52 GMT
Subject: Re: [PATCH v4 2/7] i18n: rebase: mark strings for translation
Message-ID: <CAFzf2XxTs1ynyjxRshrbOgieq-ryzBoY_p7EoGpmrPDyQomU-Q@mail.gmail.com>
In-Reply-To: <CANYiYbHnv0JppT64cnjzBgRq7_pRFHN5WMy2SAVj2GzG+dWBaA@mail.gmail.com>

Jiang Xin wrote:
> 2012/7/25 Jonathan Nieder <jrnieder@gmail.com>:

>> I haven't tested or reviewed this patch in detail, so even though it
>> looks good, I'd prefer it not to have my Reviewed-by.  (See
>> Documentation/SubmittingPatches: '"Reviewed-by:", unlike the other
>> extra tags, can only be offered by the reviewer'.)  If you'd like to
>> credit my help, something like "With advice from Jonathan." would be
>> fine.
>
> How about Acked-by: ?

I'm not area expert so my ack wouldn't count for "git rebase" or i18n,
anyway. I'm also fine with going unsung --- too many names add up to
so much noise, and in general there are some names (author, bug
reporter, and so on) that are important and shouldn't be drowned out.