git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 6/7] Remove dead code which contains bad gettext block

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jul 25, 2012, 04:30 UTC
Message-ID
<20120725043057.GC3055@burratino>
In-Reply-To
<6ab33ed2c1f637ecd2dfda411cf25b074b2d17ea.1343188013.git.worldhello.net@gmail.com>
Jiang Xin wrote:
Show 9 quoted lines
> Found this dead code when I examine gettext messages in shell scripts
> start with dash ('-' or '--'). An error will be raised for this case,
> like:
> 
>     $ gettext "-d option is no longer supported.  Do not use."
>     gettext: missing arguments
> 
> Indead, this code has been left as dead for a long time, as Junathan
> points out:
Jonathan, not Junathan. :)
Show 11 quoted lines
>     The git am -d/--dotest option has errored out with a message
>     since e72c7406 (am: remove support for -d .dotest, 2008-03-04).
>     The error message about lack of support was eliminated along
>     with other cleanups (probably by mistake) a year later by
>     removing the option from the option table in 98ef23b3 (git-am:
>     minor cleanups, 2009-01-28).
>
>     But the code to handle -d and --dotest stayed around even though
>     ever since then it could not be tripped.  Remove this dead code.
>
> Signed-off-by: Jiang Xin <worldhello.net@gmail.com>

Your explanation is certainly clearer than mine. So: yes, for what it's worth this is

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Jiang XinNext: Jonathan Nieder
Message 9 of 15 in “i18n for git-am, git-rebase and git-merge”
  1. 0/7 i18n for git-am, git-rebase and git-mergeJiang Xin, Jul 25, 2012
  2. 1/7 i18n: New keywords for xgettext extraction from shJiang Xin, Jul 25, 2012
  3. 2/7 i18n: rebase: mark strings for translationJiang Xin, Jul 25, 2012
  4. 3/7 i18n: Rewrite gettext messages start with dashJiang Xin, Jul 25, 2012
  5. 4/7 Remove obsolete LONG_USAGE which breaks xgettextJiang Xin, Jul 25, 2012
  6. 5/7 i18n: am: mark more strings for translationJiang Xin, Jul 25, 2012
  7. 6/7 Remove dead code which contains bad gettext blockJiang Xin, Jul 25, 2012
  8. 7/7 i18n: merge-recursive: mark strings for translationJiang Xin, Jul 25, 2012
  9. Jonathan NiederJul 25, 2012
  10. Jonathan NiederJul 25, 2012
  11. Stefano LattariniJul 25, 2012
  12. Jiang XinJul 25, 2012
  13. Jonathan NiederJul 25, 2012
  14. Jiang XinJul 25, 2012
  15. Jonathan NiederJul 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.