git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 10/9 v4] difftool: fix regression in '--prompt' options

From
Tim Henigan <tim.henigan@gmail.com>
Date
Mar 22, 2012, 13:51 UTC
Message-ID
<CAFouetjqzAwCe3mHkpJB4Xod4rJEF9OD77ch906TGUd9+-KZWA@mail.gmail.com>
In-Reply-To
<871uoljbe9.fsf@thomas.inf.ethz.ch>
On Thu, Mar 22, 2012 at 4:19 AM, Thomas Rast <trast@student.ethz.ch> wrote:
Show 8 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Tim Henigan <tim.henigan@gmail.com> writes:
>>
>> I really do not like the direction in which this series is going.  We do
>> not have a similar --no-gui option to defeat --gui option that may appear
>> earlier on the command line, but when we fix that bug (isn't it a bug?),
>> we would have to teach this loop about that option, wouldn't we?

Of course, Thomas is correct and the limitation was with my use of Getopt::Long rather than the module itself.

v5 of the patch will use Getopt to parse the '--[no-]prompt' options again. I will also add a new patch to the series to implement '--no-gui'.

> Limitations?  You can basically steal code from git-send-email.  As an
> example:

Thank you for the example...I should have found this when I read the documentation earlier.

Previous: Thomas RastNext: Junio C Hamano
Message 9 of 17 in “difftool: teach command to perform directory diffs”
  1. 0/9 difftool: teach command to perform directory diffsTim Henigan, Mar 21, 2012
  2. 7/9 difftool: teach difftool to handle directory diffsTim Henigan, Mar 21, 2012
  3. 8/9 difftool: teach dir-diff to copy modified files back to working treeTim Henigan, Mar 21, 2012
  4. 10/9 difftool: do not allow mix of '--prompt' with '--no-prompt'Tim Henigan, Mar 21, 2012
  5. Junio C HamanoMar 21, 2012
  6. 10/9 difftool: fix regression in '--prompt' optionsTim Henigan, Mar 22, 2012
  7. Junio C HamanoMar 22, 2012
  8. Thomas RastMar 22, 2012
  9. Tim HeniganMar 22, 2012
  10. Junio C HamanoMar 22, 2012
  11. Tim HeniganMar 22, 2012
  12. Junio C HamanoMar 22, 2012
  13. Junio C HamanoMar 22, 2012
  14. 11/9 t7800: add test for difftool --tool-helpTim Henigan, Mar 21, 2012
  15. 12/9 t7800: add tests for difftool --dir-diffTim Henigan, Mar 21, 2012
  16. David AguilarMar 22, 2012
  17. Tim HeniganMar 22, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.