git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 10/9 v4] difftool: fix regression in '--prompt' options

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 22, 2012, 04:09 UTC
Message-ID
<7viphxz37j.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1332381236-16004-1-git-send-email-tim.henigan@gmail.com>
Tim Henigan <tim.henigan@gmail.com> writes:
Show 11 quoted lines
> +# the '--prompt' and '--no-prompt' options require special treatment
> +# because they may be specified more than once...the last one "wins".
> +for (@ARGV) {
> +	if (($_ eq "-y") or ($_ eq "--no-prompt")) {
> +		$prompt = 0;
> +	} elsif ($_ eq "--prompt") {
> +		$prompt = 1;
> +	} else {
> +		push(@diffargs, $_);
> +	}
> +}

I really do not like the direction in which this series is going. We do not have a similar --no-gui option to defeat --gui option that may appear earlier on the command line, but when we fix that bug (isn't it a bug?), we would have to teach this loop about that option, wouldn't we?

In the end, won't you end up resurrecting the argument parsing loop that you got rid of with the first patch in your series? Isn't this working around the problem introduced only because you are using Getopt::Long and hitting its limitations?

Previous: Tim HeniganNext: Thomas Rast
Message 7 of 17 in “difftool: teach command to perform directory diffs”
  1. 0/9 difftool: teach command to perform directory diffsTim Henigan, Mar 21, 2012
  2. 7/9 difftool: teach difftool to handle directory diffsTim Henigan, Mar 21, 2012
  3. 8/9 difftool: teach dir-diff to copy modified files back to working treeTim Henigan, Mar 21, 2012
  4. 10/9 difftool: do not allow mix of '--prompt' with '--no-prompt'Tim Henigan, Mar 21, 2012
  5. Junio C HamanoMar 21, 2012
  6. 10/9 difftool: fix regression in '--prompt' optionsTim Henigan, Mar 22, 2012
  7. Junio C HamanoMar 22, 2012
  8. Thomas RastMar 22, 2012
  9. Tim HeniganMar 22, 2012
  10. Junio C HamanoMar 22, 2012
  11. Tim HeniganMar 22, 2012
  12. Junio C HamanoMar 22, 2012
  13. Junio C HamanoMar 22, 2012
  14. 11/9 t7800: add test for difftool --tool-helpTim Henigan, Mar 21, 2012
  15. 12/9 t7800: add tests for difftool --dir-diffTim Henigan, Mar 21, 2012
  16. David AguilarMar 22, 2012
  17. Tim HeniganMar 22, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.