Re: [PATCH v3 12/9] t7800: add tests for difftool --dir-diff
On Thu, Mar 22, 2012 at 5:53 AM, David Aguilar <davvid@gmail.com> wrote:
Show 5 quoted lines
> On Wed, Mar 21, 2012 at 12:36 PM, Tim Henigan <tim.henigan@gmail.com> wrote:
>
> If we wrap the subdir operations in parentheses then the sub-shell
> saves us from having to do "cd ..". It also helps prevent leakage
> from earlier failures, which is helpful when writing new tests.
I will update the patch to include this change. Thank you for the example.
> It'd also be pretty neat if we could gather file content somehow.
> This would allow us to make assertions about the content of the
> left/right parameters passed to the tool. I don't know if that's test
> overkill ;-) but it seems like it could be helpful.
This sounds like a good change for some future patch ;)