git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] gitweb: add the ability to show side-by-side diff on commitdiff.

From
Kato Kazuyoshi <kato.kazuyoshi@gmail.com>
Date
Oct 17, 2011, 02:33 UTC
Message-ID
<CAFo4x0KPP1yZec+98_rn9tG_fhtB-DYAcdi90TwiwUPq+DP90g@mail.gmail.com>
In-Reply-To
<7vbotgper8.fsf@alter.siamese.dyndns.org>
On Mon, Oct 17, 2011 at 10:51 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
>
> I think a better organization would be
>
>  [1/2] change code so that $diff_class does not have leading SP
>       optionally catch a case where $diff_class stays empty as an error?
>

I think we don't have to treat empty $diff_class as an error because $diff_class will be an empty when $line is around modification (ex. foo or quux).

  foo
- bar
+ baz
  quuz

And class attributes are CDATA. "diff[SP]" and "diff" have same meanings. http://www.w3.org/TR/html401/struct/global.html#h-7.5.2 http://www.w3.org/TR/html401/types.html#type-cdata

-- 
Kato Kazuyoshi
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 6 in “gitweb: add the ability to show side-by-side diff on commitdiff.”
  1. gitweb: add the ability to show side-by-side diff on commitdiff.Kato Kazuyoshi, Oct 16, 2011
  2. Junio C HamanoOct 17, 2011
  3. Kato KazuyoshiOct 17, 2011
  4. Junio C HamanoOct 17, 2011
  5. Kato KazuyoshiOct 17, 2011
  6. Junio C HamanoOct 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.