From: Kato Kazuyoshi <kato.kazuyoshi@gmail.com>
Date: Mon, 17 Oct 2011 02:33:49 GMT
Subject: Re: [PATCH/RFC] gitweb: add the ability to show side-by-side diff on commitdiff.
Message-ID: <CAFo4x0KPP1yZec+98_rn9tG_fhtB-DYAcdi90TwiwUPq+DP90g@mail.gmail.com>
In-Reply-To: <7vbotgper8.fsf@alter.siamese.dyndns.org>

On Mon, Oct 17, 2011 at 10:51 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
> I think a better organization would be
>
>  [1/2] change code so that $diff_class does not have leading SP
>       optionally catch a case where $diff_class stays empty as an error?
>

I think we don't have to treat empty $diff_class as an error because
$diff_class will be an empty when $line is around modification
(ex. foo or quux).

  foo
- bar
+ baz
  quuz

And class attributes are CDATA. "diff[SP]" and "diff" have same
meanings.
http://www.w3.org/TR/html401/struct/global.html#h-7.5.2
http://www.w3.org/TR/html401/types.html#type-cdata

-- 
Kato Kazuyoshi