Re: [PATCH/RFC] gitweb: add the ability to show side-by-side diff on commitdiff.

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 17, 2011, 03:57 UTC
Message-ID: <7v7h44p8vz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAFo4x0KPP1yZec+98_rn9tG_fhtB-DYAcdi90TwiwUPq+DP90g@mail.gmail.com>

Kato Kazuyoshi <kato.kazuyoshi@gmail.com> writes:

Show 16 quoted lines

> On Mon, Oct 17, 2011 at 10:51 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> I think a better organization would be
>>
>>  [1/2] change code so that $diff_class does not have leading SP
>>       optionally catch a case where $diff_class stays empty as an error?
>>
>
> I think we don't have to treat empty $diff_class as an error because
> $diff_class will be an empty when $line is around modification
> (ex. foo or quux).
>
>   foo
> - bar
> + baz
>   quuz

Ok. then even though class="diff " is not any different from class="diff", I have to say generated html output becomes aesthetically less nice with this change; we may want to do something about it _iff_ it does not take too much change, but as I said I do not care too much about it.