Re: [PATCH] git-add--interactive.perl: Remove two unused variables
- From
Thomas Badie <thomas.badie@gmail.com>
- Date
- Jun 25, 2012, 10:16 UTC
- Message-ID
- <CAFjFENqrGreepYXM3DrDiYEsau9-vM-qmf8KvqrNNjdCS-adjg@mail.gmail.com>
- In-Reply-To
- <87txxzu55d.fsf@thomas.inf.ethz.ch>
2012/6/25 Thomas Rast <trast@inf.ethz.ch>:
Show 15 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> "Thomas \"Enki\" Badie" <thomas.badie@gmail.com> writes: >> >>> The patch 8f0bef6 refactors this script and leaves the `$fh' variable >>> unused in `diff_applies' and `patch_update_file'. > [...] >> (2) the author of the problematic commit should have been Cc'ed >> (especially when he is still an active participant on the list) >> to give him a chance to Ack it (I'm adding Thomas for this). > > Indeed, my bad. It's easy to verify from 'git show 8f0bef6' that this > was an oversight in my patch. > > Acked-by: Thomas Rast <trast@student.ethz.ch>
It happens to everyone^^ Thanks for your answer.
Should I repost a patch V2 or it is okay like this? Thanks
-- Thomas "Enki" Badie