git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-add--interactive.perl: Remove two unused variables

From
Thomas Rast <trast@inf.ethz.ch>
Date
Jun 25, 2012, 09:12 UTC
Message-ID
<87txxzu55d.fsf@thomas.inf.ethz.ch>
In-Reply-To
<7vfw9khrrt.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
> "Thomas \"Enki\" Badie" <thomas.badie@gmail.com> writes:
>
>> The patch 8f0bef6 refactors this script and leaves the `$fh' variable
>> unused in `diff_applies' and `patch_update_file'.
[...]
>  (2) the author of the problematic commit should have been Cc'ed
>      (especially when he is still an active participant on the list)
>      to give him a chance to Ack it (I'm adding Thomas for this).

Indeed, my bad. It's easy to verify from 'git show 8f0bef6' that this was an oversight in my patch.

Acked-by: Thomas Rast <trast@student.ethz.ch>
-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Junio C HamanoNext: Thomas Badie
Message 3 of 7 in “git-add--interactive.perl: Remove two unused variables”
  1. git-add--interactive.perl: Remove two unused variablesThomas "Enki" Badie, Jun 24, 2012
  2. Junio C HamanoJun 25, 2012
  3. Thomas RastJun 25, 2012
  4. Thomas BadieJun 25, 2012
  5. Thomas BadieJun 25, 2012
  6. Junio C HamanoJun 25, 2012
  7. Thomas BadieJun 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.