Re: [PATCH] git-add--interactive.perl: Remove two unused variables

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 25, 2012, 18:06 UTC
Message-ID: <7v7guvgtbi.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAFjFENo7qLTZHrEtPPBLGzp=h0w69C+7C2zfiJJmqFANmaWAgg@mail.gmail.com>

Thomas Badie <thomas.badie@gmail.com> writes:

Show 20 quoted lines

> 2012/6/25 Junio C Hamano <gitster@pobox.com>:
>> "Thomas \"Enki\" Badie" <thomas.badie@gmail.com> writes:
>>
>>> The patch 8f0bef6 refactors this script and leaves the `$fh' variable
>>> unused in `diff_applies' and `patch_update_file'.
>>>
>>> Signed-off-by: Thomas Badie <badie@lrde.epita.fr>
>>> ---
>>> Hello,
>>> This is my first patch. It introduces a really minor change, and I
>>> also want to be sure the way I submit it is the right way. Thanks :)
>>
>> The patch submission is almost perfect, except that:
>>
>> (1) the patch seems to be whitespace damaged; and
>>
>
> The only damage I see is a space on the deleted lines which doesn't
> exist in the patch. Is that you're talking about ?
> I need to investigate why it appears...

A typical context line would begin with SP and typically then tab (because our code is indented with leading tabs) but your context lines all have two SPs in front and indented with more SPs. This is a symptom of your MUA mangling your patch, and the reason can be seen in the "Content-Type: text/plain; charset=ISO-8859-1; format=flowed" header.