git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] commit: add a commit.verbose config variable

From
Pranit Bauva <pranit.bauva@gmail.com>
Date
Mar 10, 2016, 23:02 UTC
Message-ID
<CAFZEwPNmMB5ggCFRV913wEhGTkZaGLaJgY9b_Rm_2Ho866fiUA@mail.gmail.com>
In-Reply-To
<xmqq60wuc5ev.fsf@gitster.mtv.corp.google.com>
> +     if (!strcmp(k, "commit.verbose")){
> v3 did this line correctly but you somehow lost the SP between
> "){".  What happened?
I will include the SP between )) and { .
> Don't you need a test that status is not broken when the variable is
> set?

I will include the test for status too. But I am a bit confused where should I place them? This patch triggers the possibility of a breakage in status related to verbose but other tests related to status are in different files. Could you tell me the filename where I should place these test?

Previous: Junio C HamanoNext: Eric Sunshine
Message 4 of 13 in “commit: add a commit.verbose config variable”
  1. commit: add a commit.verbose config variablePranit Bauva, Mar 10, 2016
  2. Pranit BauvaMar 10, 2016
  3. Junio C HamanoMar 10, 2016
  4. Pranit BauvaMar 10, 2016
  5. Eric SunshineMar 10, 2016
  6. Pranit BauvaMar 11, 2016
  7. Eric SunshineMar 11, 2016
  8. Pranit BauvaMar 11, 2016
  9. Roberto TyleyMar 11, 2016
  10. Philip OakleyMar 11, 2016
  11. t/t7502 : drop duplicate testPranit Bauva, Mar 11, 2016
  12. Pranit BauvaMar 11, 2016
  13. Junio C HamanoMar 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.