Re: [PATCH v2] t/t7502 : drop duplicate test

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 11, 2016, 18:39 UTC
Message-ID: <xmqqvb4samf7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <010201536326c56b-cd751f0b-f03f-4c9f-b834-20cee14b6eb5-000000@eu-west-1.amazonses.com>

Pranit Bauva <pranit.bauva@gmail.com> writes:

Show 6 quoted lines

> This extra test was introduced erroneously by
> f9c0181 (t7502: test commit.status, --status and
> --no-status, 2010-01-13)
>
> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
> ---

Thanks. I briefly thought that this might be checking that doing this twice would give different results, but that is not what is happening. Also the remainder of this does cover all the combinations, so we are OK after applying this patch.

Thanks, will queue.

Show 22 quoted lines

>  t/t7502-commit.sh | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
> index b39e313..725687d 100755
> --- a/t/t7502-commit.sh
> +++ b/t/t7502-commit.sh
> @@ -527,11 +527,6 @@ try_commit_status_combo () {
>  		test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
>  	'
>  
> -	test_expect_success 'commit' '
> -		try_commit "" &&
> -		test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
> -	'
> -
>  	test_expect_success 'commit --status' '
>  		try_commit --status &&
>  		test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
>
> --
> https://github.com/git/git/pull/208