From: Pranit Bauva <pranit.bauva@gmail.com>
Date: Thu, 10 Mar 2016 23:02:19 GMT
Subject: Re: [PATCH v4] commit: add a commit.verbose config variable
Message-ID: <CAFZEwPNmMB5ggCFRV913wEhGTkZaGLaJgY9b_Rm_2Ho866fiUA@mail.gmail.com>
In-Reply-To: <xmqq60wuc5ev.fsf@gitster.mtv.corp.google.com>

> +     if (!strcmp(k, "commit.verbose")){

> v3 did this line correctly but you somehow lost the SP between
> "){".  What happened?

I will include the SP between )) and { .

> Don't you need a test that status is not broken when the variable is
> set?

I will include the test for status too. But I am a bit confused where
should I place them? This patch triggers the possibility of a breakage
in status related to verbose but other tests related to status are in
different files. Could you tell me the filename where I should place
these test?