Re: [PATCH v15 02/27] bisect: rewrite `check_term_format` shell function in C

> Hi,
>
> I saw in the recent "What's cooking" mail that this is still waiting
> for review, so I thought I could interfere and help reviewing it from a
> non-git-developer point of view.
> But only two commits for today. The first one seems fine. The second
> one makes me write this mail ;-)

> On 10/14/2016 04:14 PM, Pranit Bauva wrote:
>> +static int check_term_format(const char *term, const char *orig_term)
>> +{
> [...]
>> +     if (one_of(term, "help", "start", "skip", "next", "reset",
>> +                     "visualize", "replay", "log", "run", NULL))
> [... vs ...]
>> -check_term_format () {
>> -     term=$1
>> -     git check-ref-format refs/bisect/"$term" ||
>> -     die "$(eval_gettext "'\$term' is not a valid term")"
>> -     case "$term" in
>> -     help|start|terms|skip|next|reset|visualize|replay|log|run)
>
> Is there a reasons why "terms" has been dropped from the list?