Re: [PATCH v15 02/27] bisect: rewrite `check_term_format` shell function in C

From: Stephan Beyer <s-beyer@gmx.net>
Date: Nov 14, 2016, 22:20 UTC
Message-ID: <61aacd44-cb6a-2bbb-7fb4-933e2505040d@gmx.net>
In-Reply-To: <01020157c38b1a74-ad2bcaff-0c92-4af4-9aa0-72d98f4945fc-000000@eu-west-1.amazonses.com>

Hi,

I saw in the recent "What's cooking" mail that this is still waiting for review, so I thought I could interfere and help reviewing it from a non-git-developer point of view. But only two commits for today. The first one seems fine. The second one makes me write this mail ;-)

On 10/14/2016 04:14 PM, Pranit Bauva wrote:

> +static int check_term_format(const char *term, const char *orig_term)
> +{

[...]

> +	if (one_of(term, "help", "start", "skip", "next", "reset",
> +			"visualize", "replay", "log", "run", NULL))

[... vs ...]

Show 6 quoted lines

> -check_term_format () {
> -	term=$1
> -	git check-ref-format refs/bisect/"$term" ||
> -	die "$(eval_gettext "'\$term' is not a valid term")"
> -	case "$term" in
> -	help|start|terms|skip|next|reset|visualize|replay|log|run)

Is there a reasons why "terms" has been dropped from the list?

Best Stephan