git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] reftable: pass pq_entry by address

From
Han-Wen Nienhuys <hanwen@google.com>
Date
Sep 13, 2022, 09:11 UTC
Message-ID
<CAFQ2z_PATan--dz79j1MUHFCobegX8id=zMxGxk5ftzwK70bnw@mail.gmail.com>
In-Reply-To
<183353220fe.d7826593472673.3445243727369286065@elijahpepe.com>
On Tue, Sep 13, 2022 at 6:53 AM Elijah Conners <business@elijahpepe.com> wrote:
>
> In merged_iter_pqueue_add, the pq_entry parameter is passed by value,
> although it exceeds 64 bytes.
LGTM.
-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Liana Sebastian
Previous: Elijah ConnersNext: Junio C Hamano
Message 2 of 9 in “reftable: pass pq_entry by address”
  1. reftable: pass pq_entry by addressElijah Conners, Sep 13, 2022
  2. Han-Wen NienhuysSep 13, 2022
  3. Junio C HamanoSep 13, 2022
  4. Elijah ConnersSep 13, 2022
  5. Han-Wen NienhuysSep 13, 2022
  6. Elijah ConnersSep 13, 2022
  7. Han-Wen NienhuysSep 15, 2022
  8. Junio C HamanoSep 15, 2022
  9. reftable: use const with the pq_entry paramElijah Conners, Sep 14, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.