Re: [PATCH] reftable: pass pq_entry by address
On Tue, Sep 13, 2022 at 7:34 PM Elijah Conners <business@elijahpepe.com> wrote:
Show 6 quoted lines
>
> Junio C Hamano <gitster@pobox.com> writes:
> > Do we have any hard guidance like "do not pass an data item whose
> > size is larger than 64 bytes" in our coding guidelines? If not,
> > make sure that the reference to 64 bytes does not look like one.
> While we don't have hard guidance like that, putting an object that exceeds 64 bytes on the stack is dangerous.
it might be a bit slower, but "dangerous"? How so?
--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Liana Sebastian
Han-Wen Nienhuys <hanwen@google.com>