Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

From: David Michael <fedora.dm0@gmail.com>
Date: Oct 26, 2014, 18:54 UTC
Message-ID: <CAEvUa7nMYn1EJhrX+Yo-T53-tqB80p_ym9i+Ua6PMLqZrAFmQw@mail.gmail.com>
In-Reply-To: <20141026183530.GA18144@peff.net>

On Sun, Oct 26, 2014 at 2:35 PM, Jeff King <peff@peff.net> wrote:

Show 12 quoted lines

> On Sun, Oct 26, 2014 at 01:45:10PM -0400, Eric Sunshine wrote:
>
>> On Sun, Oct 26, 2014 at 1:33 PM, David Michael <fedora.dm0@gmail.com> wrote:
>> > The XL C compiler can fail due to mixing library path and object
>>
>> Can you explain in the commit message the actual nature of the failure
>> so that readers can understand more precisely how this change helps?
>
> Based on past experience, it is probably "the compiler complains and
> refuses to run" (or optionally "the compiler silently ignores your
> LDFLAGS" depending on how irritating it wants to be). But it would not
> hurt to be specific.

Yes, the compiler refuses to run by default when a "-L" option occurs after a source/object file. It tries to interpret it as another file name and fails.

I believe I can work around the error with an "export _C89_CCMODE=1", but I thought I'd send the patch since this is the only occurrence of the problem, and the argument order is inconsistent with other linker commands in the file.

IBM documentation has this to say on the noted environment variable: "The default behavior of the c89/cc/c++ command is to expect all options to precede all operands. Setting this variable allows compatibility with historical implementations (other cc commands). When set to 1, the c89/cc/c++ command operates as follows: Options and operands can be interspersed. [...]"

Do you want me to resend the patch and reference the IBM documentation in the message?

Thanks.

David