git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

From
Jeff King <peff@peff.net>
Date
Oct 28, 2014, 22:12 UTC
Message-ID
<20141028221223.GA20722@peff.net>
In-Reply-To
<xmqq61f5flz6.fsf@gitster.dls.corp.google.com>
On Mon, Oct 27, 2014 at 10:42:21AM -0700, Junio C Hamano wrote:
Show 10 quoted lines
> >> I believe I can work around the error with an "export _C89_CCMODE=1",
> >> but I thought I'd send the patch since this is the only occurrence of
> >> the problem, and the argument order is inconsistent with other linker
> >> commands in the file.
> >
> > I don't think working around it makes sense. That would fix your case,
> > but nobody else's (though given how long it has been that way without
> > complaints, I suspect any other compilers this picky may have died off).
> 
> I think you meant s/nobody else's/breaks &/;

I meant "using the _C_89_CCMODE workaround does not help anybody else, because their compiler will not support it; instead we should fix the Makefile as David originally proposed".

I think we are still agreeing, though. :)
-Peff
Previous: Junio C Hamano
Message 7 of 7 in “Makefile: Reorder linker flags in the git executable rule”
  1. 2/3 Makefile: Reorder linker flags in the git executable ruleDavid Michael, Oct 26, 2014
  2. Eric SunshineOct 26, 2014
  3. Jeff KingOct 26, 2014
  4. David MichaelOct 26, 2014
  5. Jeff KingOct 27, 2014
  6. Junio C HamanoOct 27, 2014
  7. Jeff KingOct 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.