git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

From
Jeff King <peff@peff.net>
Date
Oct 26, 2014, 18:35 UTC
Message-ID
<20141026183530.GA18144@peff.net>
In-Reply-To
<CAPig+cRUxXw4b2z1Gu4p6GKjnYrt_70h3kbR+jzbMP_jY24Sjg@mail.gmail.com>
On Sun, Oct 26, 2014 at 01:45:10PM -0400, Eric Sunshine wrote:
Show 5 quoted lines
> On Sun, Oct 26, 2014 at 1:33 PM, David Michael <fedora.dm0@gmail.com> wrote:
> > The XL C compiler can fail due to mixing library path and object
> 
> Can you explain in the commit message the actual nature of the failure
> so that readers can understand more precisely how this change helps?

Based on past experience, it is probably "the compiler complains and refuses to run" (or optionally "the compiler silently ignores your LDFLAGS" depending on how irritating it wants to be). But it would not hurt to be specific.

Either way, the patch looks good; the whole point of LDFLAGS versus LIBS is to make this distinction in command-line positioning.

-Peff
Previous: Eric SunshineNext: David Michael
Message 3 of 7 in “Makefile: Reorder linker flags in the git executable rule”
  1. 2/3 Makefile: Reorder linker flags in the git executable ruleDavid Michael, Oct 26, 2014
  2. Eric SunshineOct 26, 2014
  3. Jeff KingOct 26, 2014
  4. David MichaelOct 26, 2014
  5. Jeff KingOct 27, 2014
  6. Junio C HamanoOct 27, 2014
  7. Jeff KingOct 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.