git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] prepare_packed_git(): refactor garbage reporting in pack directory

From
Doug Kelly <dougk.ff7@gmail.com>
Date
Jan 13, 2016, 20:19 UTC
Message-ID
<CAEtYS8RA2HONEARQ03EiT8Ch+F2am+YJuRz2hNiSGO25N8Lf4g@mail.gmail.com>
In-Reply-To
<xmqqvb6xmedw.fsf@gitster.mtv.corp.google.com>
On Wed, Jan 13, 2016 at 2:08 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> Doug Kelly <dougk.ff7@gmail.com> writes:
>
>> Yeah, I know I never got to adding the mtime logic, but for a simple (naive,
>> hard-coded) case, I did come up with a basic patch today.  I think this could
>> be extended to a configuration option(?) which would allow a default longer
>> than 10 seconds (an hour? a day?), then during the regression tests, we
>> could provide a shorter timeout to ensure the guarding both works and also
>> not wait forever for tests to complete.  Thoughts?
>
> Please do not sleep in the tests.  Instead, please try to see if you
> can use test-chmtime to set the timestamps of these files to the
> necessary ages for the purpose of your tests.
>
> Thanks.

Ah, thanks -- I actually didn't know about that. I didn't intend this to be a formal patch (although I'm sorry the mail client clobbered all the whitespace), but I will keep this in mind for when I continue to refine this change.

However, back to the point: should the wait value be hard coded? Configurable as a new option? What should our default wait be?

Thanks!
Previous: Junio C HamanoNext: Jeff King
Message 30 of 34 in “Question: .idx without .pack causes performance issues?”
  1. Doug KellyJul 21, 2015
  2. Junio C HamanoJul 21, 2015
  3. Junio C HamanoJul 21, 2015
  4. Junio C HamanoJul 21, 2015
  5. Doug KellyJul 21, 2015
  6. Doug KellyAug 3, 2015
  7. Junio C HamanoAug 4, 2015
  8. Doug KellyAug 7, 2015
  9. Junio C HamanoAug 7, 2015
  10. 1/2 prepare_packed_git(): refactor garbage reporting in pack directoryDoug Kelly, Aug 13, 2015
  11. 2/2 gc: Remove garbage .idx files from pack dirDoug Kelly, Aug 13, 2015
  12. Junio C HamanoAug 17, 2015
  13. Junio C HamanoAug 17, 2015
  14. Eric SunshineAug 13, 2015
  15. Junio C HamanoAug 17, 2015
  16. Junio C HamanoOct 28, 2015
  17. Doug KellyOct 28, 2015
  18. 1/3 prepare_packed_git(): refactor garbage reporting in pack directoryDoug Kelly, Nov 4, 2015
  19. 2/3 t5304: Add test for cleaning pack garbageDoug Kelly, Nov 4, 2015
  20. 3/3 gc: Remove garbage .idx files from pack dirDoug Kelly, Nov 4, 2015
  21. Doug KellyNov 4, 2015
  22. Junio C HamanoNov 4, 2015
  23. Doug KellyNov 4, 2015
  24. Jeff KingNov 4, 2015
  25. Doug KellyNov 4, 2015
  26. Jeff KingNov 4, 2015
  27. Jeff KingDec 30, 2015
  28. Doug KellyJan 13, 2016
  29. Junio C HamanoJan 13, 2016
  30. Doug KellyJan 13, 2016
  31. Jeff KingJan 13, 2016
  32. Jeff KingNov 4, 2015
  33. Doug KellyJul 21, 2015
  34. Fwd: Question: .idx without .pack causes performance issues?Thomas Berg, Nov 11, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.