Re: [PATCH 1/2] prepare_packed_git(): refactor garbage reporting in pack directory

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 17, 2015, 16:53 UTC
Message-ID: <xmqq37zhg8la.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAPig+cS0ntr1sYzVAPjNCwd8ei4oGQRNs+W=qMBV4Z6NaRWCWA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 7 quoted lines

>> -static void real_report_garbage(const char *desc, const char *path)
>> +const char *bits_to_msg(unsigned seen_bits)
>
> If you don't expect other callers outside this file, then this should
> be declared 'static'. If you do expect future external callers, then
> this should be declared in a public header file (but renamed to be
> more meaningful).

I think this can be private to this file. The sole point of moving this logic to this file is to make it private, after all ;-) Thanks for sharp eyes.

Together with the need for a description on "why", this probably deserves a test or two, probably at the end of t5304.

Thanks.