From: Doug Kelly Date: Wed, 13 Jan 2016 20:19:05 GMT Subject: Re: [PATCH 1/2] prepare_packed_git(): refactor garbage reporting in pack directory Message-ID: In-Reply-To: On Wed, Jan 13, 2016 at 2:08 PM, Junio C Hamano wrote: > Doug Kelly writes: > >> Yeah, I know I never got to adding the mtime logic, but for a simple (naive, >> hard-coded) case, I did come up with a basic patch today. I think this could >> be extended to a configuration option(?) which would allow a default longer >> than 10 seconds (an hour? a day?), then during the regression tests, we >> could provide a shorter timeout to ensure the guarding both works and also >> not wait forever for tests to complete. Thoughts? > > Please do not sleep in the tests. Instead, please try to see if you > can use test-chmtime to set the timestamps of these files to the > necessary ages for the purpose of your tests. > > Thanks. Ah, thanks -- I actually didn't know about that. I didn't intend this to be a formal patch (although I'm sorry the mail client clobbered all the whitespace), but I will keep this in mind for when I continue to refine this change. However, back to the point: should the wait value be hard coded? Configurable as a new option? What should our default wait be? Thanks!