Re: [PATCH 1/3] git-multimail: Add an option to filter on branches

From: Dave Boutcher <daveboutcher@gmail.com>
Date: Apr 23, 2015, 01:48 UTC
Message-ID: <CAEXuECj=m-TVfVzQAtw91bfgMEUvPDt4_PtN73SxWDWSZebpow@mail.gmail.com>
In-Reply-To: <553789B6.7030501@alum.mit.edu>

On Wed, Apr 22, 2015 at 7:44 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:

> I think what you are looking for is
>
>     return any(r.match(branch) for r in branches)

Yup, thats exactly what I wanted.  I'll submit an updated patch

> I was also wondering why you decided to support comma-separated lists of
> regexps *and* multivalued config settings. It seems that supporting only
> multivalued settings would suffice.

In practice we are using gitolite and git-multimail. Allowing both means our gitolite.conf file can look like

repo foo
    # always notify on master
    config multimailhook.branches     = master

   # notify for the current pre-release branches
   config multimailhook.branches     = v1.7-pre, v1.8-pre

-- 
Dave B