Re: [PATCH 1/3] git-multimail: Add an option to filter on branches

From: Dave Boutcher <daveboutcher@gmail.com>
Date: Apr 22, 2015, 10:46 UTC
Message-ID: <CAEXuECi=UDo7_0O22+Gi1yew1M=LrrKLXNT9gdSvdgQwCxYjow@mail.gmail.com>
In-Reply-To: <55377A60.707@alum.mit.edu>

Thanks Michael,

The only code I'm not fond of is matching on a list of regular expressions. There must be a more pythonic way to do:

+ return [x for x in [r.match(branch) for r in branches] if x]

which basically returns true if "branch" matches any regular expression in the list.

I pushed this change out to our production git server (its good to be the king.) I'll obviously update here if it does anything too unfortunate.

On Wed, Apr 22, 2015 at 6:39 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:

Show 21 quoted lines

> On 04/22/2015 01:04 AM, Dave Boutcher wrote:
>> Add a branches option to the config.  Only changes
>> pushed to specified branches will generate emails. Changes to tags
>> will continue to generate emails.
>
> Thanks for the patches. Patches 2 and 3 seem uncontroversial, so I
> already merged them. Patch 1 is more interesting, and there have been
> other proposals for similar features, so I created a pull request for it:
>
>     https://github.com/git-multimail/git-multimail/pull/75
>
> (Note the new URL--I just created a GitHub "organization" for
> git-multimail to make it easier for other people to get involved. More
> info soon...)
>
> Michael
>
> --
> Michael Haggerty
> mhagger@alum.mit.edu
>

-- 
Dave B
包小龙