git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] git-multimail: Add an option to filter on branches

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Apr 22, 2015, 11:44 UTC
Message-ID
<553789B6.7030501@alum.mit.edu>
In-Reply-To
<CAEXuECi=UDo7_0O22+Gi1yew1M=LrrKLXNT9gdSvdgQwCxYjow@mail.gmail.com>
On 04/22/2015 12:46 PM, Dave Boutcher wrote:
Show 7 quoted lines
> The only code I'm not fond of is matching on a list of regular
> expressions.  There must be a more pythonic way to do:
> 
> + return [x for x in [r.match(branch) for r in branches] if x]
> 
> which basically returns true if "branch" matches any regular
> expression in the list.
I think what you are looking for is
    return any(r.match(branch) for r in branches)

This also has the advantage of stopping processing as soon as it finds a match.

I was also wondering why you decided to support comma-separated lists of regexps *and* multivalued config settings. It seems that supporting only multivalued settings would suffice.

Maybe you are following the precedent of our email configuration settings, which support comma-separated lists of email addresses? If so, I don't think that is necessary. The email support is there for backwards compatibility and because comma-separated email addresses are a thing in RFC 2822. Neither of these arguments apply to branch regexps.

> I pushed this change out to our production git server (its good to be
> the king.)  I'll obviously update here if it does anything too
> unfortunate.
Thanks.
Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
Previous: Dave BoutcherNext: Dave Boutcher
Message 6 of 7 in “git-multimail: Add an option to filter on branches”
  1. 1/3 git-multimail: Add an option to filter on branchesDave Boutcher, Apr 21, 2015
  2. 2/3 git-multimail: Add a quiet option to prevent outputting email addresses from hookDave Boutcher, Apr 21, 2015
  3. 3/3 git-multimail: Add stdout option to configDave Boutcher, Apr 21, 2015
  4. Michael HaggertyApr 22, 2015
  5. Dave BoutcherApr 22, 2015
  6. Michael HaggertyApr 22, 2015
  7. Dave BoutcherApr 23, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.