Re: [GSOC PATCH v2 2/2] attr: use `repo_settings_get_attributesfile_path()` and update callers

From: Ayush Chandekar <ayu.chandekar@gmail.com>
Date: Mar 11, 2025, 17:41 UTC
Message-ID: <CAE7as+YBnOd3jTYVzmHNjei0gjhMwsV3XGk1Y7Vi45CvzJTo4A@mail.gmail.com>
In-Reply-To: <CAOLa=ZT=zGTF2DLEy9VjXhcUN3wEi7_R=8O6nV-TtBXKT=ENXg@mail.gmail.com>

> Can't we modify 'git_check_attr()' to also receive a 'repository'? If
> not, perhaps it would be much simpler to simply pass 'the_repository'
> everywhere and cleanup this file in another follow up series?
>

Right, that was one of the things I considered too. But since `git_check_attr()` is used in a lot of widely used code paths that don't currently pass a struct repository, it felt like threading repo through all of them would create a much larger change that I intended for this patch series.

That's why I decided to stick with `the_repository` for now, and perhaps revisit the cleanup in a follow-up series once the proposed changes are accepted by the community.