From: Ayush Chandekar Date: Tue, 11 Mar 2025 17:41:43 GMT Subject: Re: [GSOC PATCH v2 2/2] attr: use `repo_settings_get_attributesfile_path()` and update callers Message-ID: In-Reply-To: > Can't we modify 'git_check_attr()' to also receive a 'repository'? If > not, perhaps it would be much simpler to simply pass 'the_repository' > everywhere and cleanup this file in another follow up series? > Right, that was one of the things I considered too. But since `git_check_attr()` is used in a lot of widely used code paths that don't currently pass a struct repository, it felt like threading repo through all of them would create a much larger change that I intended for this patch series. That's why I decided to stick with `the_repository` for now, and perhaps revisit the cleanup in a follow-up series once the proposed changes are accepted by the community.