Re: [PATCH] environment: move access to "core.attributesfile" into repo settings

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 10, 2025, 19:25 UTC
Message-ID: <xmqqcyeo7kno.fsf@gitster.g>
In-Reply-To: <CAE7as+aSRuo9sFxSX8M66HB3EOH+_OwugAnAJfN800_6GiDqBQ@mail.gmail.com>

Ayush Chandekar <ayu.chandekar@gmail.com> writes:

> But in the long term, isn’t our goal to get rid of the_repository anyway?
> So at some point, wouldn't we need to either attach attributes to a
> repository or have the attribute set know about its repository?

My point is that it may not help further the cause of removing the assumption that certain operations only work on the_repository and not on an arbitrary "struct repository" instance, to muck with the attribute subsystem. If it turns out that attribute data should not belong to a repository instance, then it would not help to have the globals moved to members of "struct repository" and pass a repository instance down the code paths. Rather, it may turn out that we are better off passing a separate structure that is *NOT* a "struct repository" that represents the set(s) of attributes down the same code paths.