git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 1/2] git p4: Fixing script editor checks

From
Luke Diamand <luke@diamand.org>
Date
Apr 11, 2012, 18:51 UTC
Message-ID
<CAE5ih7_X=4gewga8fMzaEvowsJsA1Ta9PQ2bGixx5eVvykputA@mail.gmail.com>
In-Reply-To
<7vpqbekx7h.fsf@alter.siamese.dyndns.org>
On Wed, Apr 11, 2012 at 7:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> Luke Diamand <luke@diamand.org> writes:
>
>> If P4EDITOR is defined, the tests will fail when "git p4" starts an
>> editor.
>
> Is that a problem specific to tests, or should "git p4" itself unset that
> environment?  If it is a problem specific to tests, would it be a better
> fix to add "P4EDITOR=:" like we do for EDITOR in t/test-lib.sh?

Yes and no - git-p4.py will run $P4EDITOR if it is set, even if it's just empty. So it would need a small fix to check for an empty string. I can submit a suitable patch.

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 9 in “[PATCHv2 0/2] git p4 - import/export of git/p4 tags and labels”
  1. Luke DiamandApr 11, 2012
  2. 1/2 git p4: Fixing script editor checksLuke Diamand, Apr 11, 2012
  3. Junio C HamanoApr 11, 2012
  4. Luke DiamandApr 11, 2012
  5. Junio C HamanoApr 11, 2012
  6. Luke DiamandApr 11, 2012
  7. 2/2 git p4: import/export of labels to/from p4Luke Diamand, Apr 11, 2012
  8. Pete WyckoffApr 18, 2012
  9. Luke DiamandApr 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.