git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 1/2] git p4: Fixing script editor checks

From
Luke Diamand <luke@diamand.org>
Date
Apr 11, 2012, 15:21 UTC
Message-ID
<1334157684-31402-2-git-send-email-luke@diamand.org>
In-Reply-To
<1334157684-31402-1-git-send-email-luke@diamand.org>

If P4EDITOR is defined, the tests will fail when "git p4" starts an editor.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 t/t9800-git-p4-basic.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t9800-git-p4-basic.sh b/t/t9800-git-p4-basic.sh
index 13be144..b2f0869 100755
--- a/t/t9800-git-p4-basic.sh
+++ b/t/t9800-git-p4-basic.sh
@@ -335,7 +335,7 @@ test_expect_success 'detect renames' '
 	test_when_finished cleanup_git &&
 	(
 		cd "$git" &&
-		git config git-p4.skipSubmitEditCheck true &&
+		git config git-p4.skipSubmitEdit true &&
 
 		git mv file1 file4 &&
 		git commit -a -m "Rename file1 to file4" &&
@@ -394,7 +394,7 @@ test_expect_success 'detect copies' '
 	test_when_finished cleanup_git &&
 	(
 		cd "$git" &&
-		git config git-p4.skipSubmitEditCheck true &&
+		git config git-p4.skipSubmitEdit true &&
 
 		cp file2 file8 &&
 		git add file8 &&
-- 
1.7.10.rc0.161.gdb6eba
Previous: Luke DiamandNext: Junio C Hamano
Message 2 of 9 in “[PATCHv2 0/2] git p4 - import/export of git/p4 tags and labels”
  1. Luke DiamandApr 11, 2012
  2. 1/2 git p4: Fixing script editor checksLuke Diamand, Apr 11, 2012
  3. Junio C HamanoApr 11, 2012
  4. Luke DiamandApr 11, 2012
  5. Junio C HamanoApr 11, 2012
  6. Luke DiamandApr 11, 2012
  7. 2/2 git p4: import/export of labels to/from p4Luke Diamand, Apr 11, 2012
  8. Pete WyckoffApr 18, 2012
  9. Luke DiamandApr 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.