From: Luke Diamand <luke@diamand.org>
Date: Wed, 11 Apr 2012 18:51:45 GMT
Subject: Re: [PATCHv2 1/2] git p4: Fixing script editor checks
Message-ID: <CAE5ih7_X=4gewga8fMzaEvowsJsA1Ta9PQ2bGixx5eVvykputA@mail.gmail.com>
In-Reply-To: <7vpqbekx7h.fsf@alter.siamese.dyndns.org>

On Wed, Apr 11, 2012 at 7:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Luke Diamand <luke@diamand.org> writes:
>
>> If P4EDITOR is defined, the tests will fail when "git p4" starts an
>> editor.
>
> Is that a problem specific to tests, or should "git p4" itself unset that
> environment?  If it is a problem specific to tests, would it be a better
> fix to add "P4EDITOR=:" like we do for EDITOR in t/test-lib.sh?

Yes and no - git-p4.py will run $P4EDITOR if it is set, even if it's
just empty. So it would need a small fix to check for an empty string.
I can submit a suitable patch.