Re: [PATCH v5] git-p4: Obey core.ignorecase when using P4 client specs.

From: Luke Diamand <luke@diamand.org>
Date: Aug 26, 2015, 10:18 UTC
Message-ID: <CAE5ih791vqnyk_J8Sq9LXq+WZW31OwEuCiD6-wwVLo-tXxHOMA@mail.gmail.com>
In-Reply-To: <55DCB2E0.5090605@diamand.org>

On 25 August 2015 at 19:24, Luke Diamand <luke@diamand.org> wrote:

Show 22 quoted lines

> On 25/08/15 14:14, Lars Schneider wrote:
>>>
>>>
>>> So the choices are:
>>>
>>> 1. A new command-line option which would silently set core.ignorecase
>>> 2. Users just have to know to set core.ignorecase manually before
>>> using git-p4 (i.e. Lars' patch v5)
>>> 3. Fix fast-import to take a --casefold option (but that's a much bigger
>>> change)
>>>
>> I vote for 2 because that solves the problem consistently with the
>> existing implementation for now. That means we don’t surprise git-p4 users.
>> In addition I would try to fix (3), the —casefold option, in a separate
>> patch. Although this (3) patch could take a bit as I have two more git-p4
>> patches in the queue that I want to propose to the mailing list first.
>
>
> That works for me. Ack.
>
> Thanks!
> Luke

Lars - could you resubmit PATCHv5 as v6, with Acked-by from me added after the Signed-off-by: line. It then this from SubmittingPatches:

> After the list reached a consensus that it is a good idea to apply the
> patch, re-send it with "To:" set to the maintainer [*1*] and "cc:" the
> list [*2*] for inclusion.

Thanks Luke