Re: [PATCH v5] git-p4: Obey core.ignorecase when using P4 client specs.
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Aug 25, 2015, 08:33 UTC
- Message-ID
- <55DC285D.9030500@web.de>
- In-Reply-To
- <55DC111A.6090501@diamand.org>
On 08/25/2015 08:54 AM, Luke Diamand wrote:
Show 23 quoted lines
> On 24/08/15 22:30, larsxschneider@gmail.com wrote: >> From: Lars Schneider <larsxschneider@gmail.com> >> >> Thanks to Luke Diamand I realized the core problem and propose here a >> substiantially simpler fix to my PATCH v4. >> >> The test cases remain and prove the problem. In particular >> "8 - Clone path (ignorecase)" and >> "Add a new file and clone path with new file (ignorecase)" fail with the >> current implementation on OS X and Linux. > > That's a lot simpler, thanks! > > Could we give this its own command line option and git config variable? > > Core.ignorecase gets set if the client is on a filing system that > ignores case. This is slightly different - it squashes case in depot > files for people with depots that have incorrectly jumbled-up case. > > Conflating the two seems like it would cause confusion at some point - > for example, I have no idea how the rest of git behaves if > core.ignorecase is set to True on a case-preserving file system. >
That doesn't work as expected and is not allowed (or say strictly forbidden, or strongly recommended not to do)
Remembering older discussions about importers from foreign VCS: This should work best for most people: Look at the command line option, if no one is given, look at core.ignorecase.
So the command line option overrides core.ignorecase, and the user can either run --ignore-path-case or --no-ignore-path-case PS: Need to drop Eric from the list: the MX/A from from web.de problem still exists