Re: [PATCH v5] git-p4: Obey core.ignorecase when using P4 client specs.
- From
Luke Diamand <luke@diamand.org>
- Date
- Aug 25, 2015, 18:24 UTC
- Message-ID
- <55DCB2E0.5090605@diamand.org>
- In-Reply-To
- <B7632D9A-BB8B-41E5-9C3D-F7376A0C81D3@gmail.com>
On 25/08/15 14:14, Lars Schneider wrote:
Show 9 quoted lines
>> >> So the choices are: >> >> 1. A new command-line option which would silently set core.ignorecase >> 2. Users just have to know to set core.ignorecase manually before >> using git-p4 (i.e. Lars' patch v5) >> 3. Fix fast-import to take a --casefold option (but that's a much bigger change) >> > I vote for 2 because that solves the problem consistently with the existing implementation for now. That means we don’t surprise git-p4 users. In addition I would try to fix (3), the —casefold option, in a separate patch. Although this (3) patch could take a bit as I have two more git-p4 patches in the queue that I want to propose to the mailing list first.
That works for me. Ack.
Thanks! Luke