Re: [PATCH] setup.c: Fix prefix_pathspec from looping pass end of string

From: Andrew Wong <andrew.kw.w@gmail.com>
Date: Mar 7, 2013, 22:25 UTC
Message-ID: <CADgNjakrBCD2jMNUz95E-7FkyKmNgcQeuz8grDWczb-hM6yHhg@mail.gmail.com>
In-Reply-To: <7vobeulw4d.fsf@alter.siamese.dyndns.org>

On 3/7/13, Junio C Hamano <gitster@pobox.com> wrote:

> The parser that goes past the end of the string may be a bug worth
> fixing, but is this patch sufficient to diagnose such an input as an
> error?

Yea, the patch should fix the passing end of string too. The parser was going past end of string because the nextat is set to "copyfrom + len + 1" for the '\0' case too. Then "+ 1" causes the parser to go pass end of string. If we handle the '\0' case separately, then the parser ends properly, and shouldn't be able to go pass the end of string.

Hm, should I be paranoid and put an "else" clause to call die() as well? In case there's a scenario where none of the 3 cases is true...

Andrew