git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] setup.c: Check that the pathspec magic ends with ")"

From
Andrew Wong <andrew.kw.w@gmail.com>
Date
Mar 9, 2013, 23:46 UTC
Message-ID
<1362872760-25803-2-git-send-email-andrew.kw.w@gmail.com>
In-Reply-To
<1362872760-25803-1-git-send-email-andrew.kw.w@gmail.com>
The previous code allowed the ")" to be optional.
Signed-off-by: Andrew Wong <andrew.kw.w@gmail.com>
---
 setup.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/setup.c b/setup.c
index f4c4e73..5ed2b93 100644
--- a/setup.c
+++ b/setup.c
@@ -225,8 +225,9 @@ static const char *prefix_pathspec(const char *prefix, int prefixlen, const char
 				die("Invalid pathspec magic '%.*s' in '%s'",
 				    (int) len, copyfrom, elt);
 		}
-		if (*copyfrom == ')')
-			copyfrom++;
+		if (*copyfrom != ')')
+			die("Missing ')' at the end of pathspec magic in '%s'", elt);
+		copyfrom++;
 	} else {
 		/* shorthand */
 		for (copyfrom = elt + 1;
-- 
1.7.12.4
Previous: Andrew Wong
Message 9 of 9 in “setup.c: Fix prefix_pathspec from looping pass end of string”
  1. setup.c: Fix prefix_pathspec from looping pass end of stringAndrew Wong, Mar 7, 2013
  2. Junio C HamanoMar 7, 2013
  3. Andrew WongMar 7, 2013
  4. Junio C HamanoMar 7, 2013
  5. Andrew WongMar 8, 2013
  6. Junio C HamanoMar 8, 2013
  7. Andrew WongMar 8, 2013
  8. 1/2 setup.c: Fix prefix_pathspec from looping pass end of stringAndrew Wong, Mar 9, 2013
  9. 2/2 setup.c: Check that the pathspec magic ends with ")"Andrew Wong, Mar 9, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.