Re: [PATCH] setup.c: Fix prefix_pathspec from looping pass end of string

From: Andrew Wong <andrew.kw.w@gmail.com>
Date: Mar 8, 2013, 01:58 UTC
Message-ID: <513945CA.6070302@gmail.com>
In-Reply-To: <7vk3pik6aq.fsf@alter.siamese.dyndns.org>

On 03/07/13 20:51, Junio C Hamano wrote:

> But it is equally broken to behave as if there is nothing wrong in
> the incomplete magic ":(top" that is not closed, isn't it?

Ah, yea, I did notice that, but then I saw a few lines below:
        if (*copyfrom == ')')
            copyfrom++;
which is explicitly making the ")" optional. So I thought maybe that was
the original intention, and left it at that. Though the doc says to end
with ")", so I guess it should error out after all? If that's the case,
I can try to come up with a patch to error it out (through die() ?).